fix(clerk-js): Handle gracefully Coinbase Wallet use of existing Passkey - #4302
Merged
chanioxaris merged 1 commit intoOct 8, 2024
Conversation
chanioxaris
requested review from
anagstef,
nikosdouvlis,
nikospapcom,
octoper and
panteliselef
October 8, 2024 11:45
🦋 Changeset detectedLatest commit: 25e208f The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
anagstef
approved these changes
Oct 8, 2024
There is a chance that as a user when you try to setup and use the Coinbase Wallet with an existing Passkey in order to authenticate, the initial generate signature request to be rejected. For this reason we retry the request once more in order for the flow to be able to be completed successfully.
chanioxaris
force-pushed
the
haris/user-831-connect-an-existing-coinbase-wallet-passkey-fails-to
branch
from
October 8, 2024 11:50
3a6b163 to
25e208f
Compare
nikospapcom
approved these changes
Oct 8, 2024
chanioxaris
deleted the
haris/user-831-connect-an-existing-coinbase-wallet-passkey-fails-to
branch
October 8, 2024 12:02
chanioxaris
pushed a commit
that referenced
this pull request
Oct 8, 2024
wobsoriano
pushed a commit
that referenced
this pull request
Feb 8, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
There is a chance that as a user when you try to setup and use the Coinbase Wallet with an existing Passkey in order to authenticate, the initial generate signature request to be rejected. For this reason we retry the request once more in order for the flow to be able to be completed successfully.
Before
before.mov
After
after.mov
Checklist
npm testruns as expected.npm run buildruns as expected.Type of change